Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove debugging statement and change getBy query to findBy #1596

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

regexowl
Copy link
Collaborator

This removes a leftover debugging statement and changes getBy query to an awaited async findBy as this was causing problems in the test when the checked component wasn't immediately available.

@regexowl
Copy link
Collaborator Author

Also prepared a PR to catch the debugging statements during linting in the future: #1597

Copy link
Collaborator

@lucasgarfield lucasgarfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

This removes a leftover debugging statement and changes `getBy` query to an awaited async `findBy` as this was causing problems in the test when the checked component wasn't immediately available.
@lucasgarfield lucasgarfield enabled auto-merge (rebase) January 25, 2024 13:53
@lucasgarfield lucasgarfield merged commit 269293e into osbuild:main Jan 25, 2024
2 of 3 checks passed
@regexowl regexowl deleted the fix-testing branch January 25, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍼 simple Simple and quick to review ✅ ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants